Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/kubernetes: Upgrade K8S to 1.6.1 #14923

Merged
merged 8 commits into from
May 31, 2017
Merged

provider/kubernetes: Upgrade K8S to 1.6.1 #14923

merged 8 commits into from
May 31, 2017

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented May 30, 2017 •
edited
Loading

Why

Although we wanted to avoid the upgrade until we ship all v1 resources we discovered a slightly annoying behaviour in pod - specifically kubelet automounting secrets by default. It is possible to turn off that behaviour in 1.6 and avoid spurious diffs and generally avoid the complexity of figuring out what's default (automounted) and what was defined by the user.

TL;DR To unblock #13571

How did it go?

I tried upgrading to the latest stable version (1.6.4) but I was unable to put all the dependency puzzle pieces together. Apparently the K8S project decided to split the main repo into multiple different ones and they seem to be in some kind of transition phase still which makes vendoring a nontrivial task especially due to the way the main k8s project does vendoring for other k8s projects.

The commit messages should be self-explanatory.

Test plan

make testacc TEST=./builtin/providers/kubernetes TESTARGS='-run=TestAccKubernetes'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/30 08:22:10 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/kubernetes -v -run=TestAccKubernetes -timeout 120m
=== RUN   TestAccKubernetesConfigMap_basic
--- PASS: TestAccKubernetesConfigMap_basic (6.11s)
=== RUN   TestAccKubernetesConfigMap_importBasic
--- PASS: TestAccKubernetesConfigMap_importBasic (2.15s)
=== RUN   TestAccKubernetesConfigMap_generatedName
--- PASS: TestAccKubernetesConfigMap_generatedName (2.04s)
=== RUN   TestAccKubernetesConfigMap_importGeneratedName
--- PASS: TestAccKubernetesConfigMap_importGeneratedName (2.12s)
=== RUN   TestAccKubernetesHorizontalPodAutoscaler_basic
--- PASS: TestAccKubernetesHorizontalPodAutoscaler_basic (4.54s)
=== RUN   TestAccKubernetesHorizontalPodAutoscaler_generatedName
--- PASS: TestAccKubernetesHorizontalPodAutoscaler_generatedName (1.88s)
=== RUN   TestAccKubernetesHorizontalPodAutoscaler_importBasic
--- PASS: TestAccKubernetesHorizontalPodAutoscaler_importBasic (2.29s)
=== RUN   TestAccKubernetesLimitRange_basic
--- PASS: TestAccKubernetesLimitRange_basic (5.26s)
=== RUN   TestAccKubernetesLimitRange_generatedName
--- PASS: TestAccKubernetesLimitRange_generatedName (1.37s)
=== RUN   TestAccKubernetesLimitRange_typeChange
--- PASS: TestAccKubernetesLimitRange_typeChange (3.54s)
=== RUN   TestAccKubernetesLimitRange_multipleLimits
--- PASS: TestAccKubernetesLimitRange_multipleLimits (2.30s)
=== RUN   TestAccKubernetesLimitRange_importBasic
--- PASS: TestAccKubernetesLimitRange_importBasic (2.16s)
=== RUN   TestAccKubernetesNamespace_basic
--- PASS: TestAccKubernetesNamespace_basic (13.20s)
=== RUN   TestAccKubernetesNamespace_importBasic
--- PASS: TestAccKubernetesNamespace_importBasic (6.69s)
=== RUN   TestAccKubernetesNamespace_generatedName
--- PASS: TestAccKubernetesNamespace_generatedName (6.37s)
=== RUN   TestAccKubernetesNamespace_importGeneratedName
--- PASS: TestAccKubernetesNamespace_importGeneratedName (6.81s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_basic
--- PASS: TestAccKubernetesPersistentVolumeClaim_basic (3.64s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_importBasic
--- PASS: TestAccKubernetesPersistentVolumeClaim_importBasic (4.77s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_volumeMatch
--- PASS: TestAccKubernetesPersistentVolumeClaim_volumeMatch (22.88s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_labelsMatch
--- PASS: TestAccKubernetesPersistentVolumeClaim_labelsMatch (2.29s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_labelsMatchExpression
--- PASS: TestAccKubernetesPersistentVolumeClaim_labelsMatchExpression (10.08s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_volumeUpdate
--- PASS: TestAccKubernetesPersistentVolumeClaim_volumeUpdate (6.81s)
=== RUN   TestAccKubernetesPersistentVolume_basic
--- PASS: TestAccKubernetesPersistentVolume_basic (3.24s)
=== RUN   TestAccKubernetesPersistentVolume_importBasic
--- PASS: TestAccKubernetesPersistentVolume_importBasic (3.00s)
=== RUN   TestAccKubernetesPersistentVolume_volumeSource
--- PASS: TestAccKubernetesPersistentVolume_volumeSource (3.14s)
=== RUN   TestAccKubernetesPersistentVolume_cephFsSecretRef
--- PASS: TestAccKubernetesPersistentVolume_cephFsSecretRef (2.30s)
=== RUN   TestAccKubernetesResourceQuota_basic
--- PASS: TestAccKubernetesResourceQuota_basic (6.82s)
=== RUN   TestAccKubernetesResourceQuota_generatedName
--- PASS: TestAccKubernetesResourceQuota_generatedName (2.40s)
=== RUN   TestAccKubernetesResourceQuota_withScopes
--- PASS: TestAccKubernetesResourceQuota_withScopes (4.22s)
=== RUN   TestAccKubernetesResourceQuota_importBasic
--- PASS: TestAccKubernetesResourceQuota_importBasic (2.65s)
=== RUN   TestAccKubernetesSecret_basic
--- PASS: TestAccKubernetesSecret_basic (7.73s)
=== RUN   TestAccKubernetesSecret_importBasic
--- PASS: TestAccKubernetesSecret_importBasic (2.46s)
=== RUN   TestAccKubernetesSecret_generatedName
--- PASS: TestAccKubernetesSecret_generatedName (1.68s)
=== RUN   TestAccKubernetesSecret_importGeneratedName
--- PASS: TestAccKubernetesSecret_importGeneratedName (1.89s)
=== RUN   TestAccKubernetesService_basic
--- PASS: TestAccKubernetesService_basic (4.11s)
=== RUN   TestAccKubernetesService_loadBalancer
--- PASS: TestAccKubernetesService_loadBalancer (4.06s)
=== RUN   TestAccKubernetesService_nodePort
--- PASS: TestAccKubernetesService_nodePort (1.78s)
=== RUN   TestAccKubernetesService_importBasic
--- PASS: TestAccKubernetesService_importBasic (2.46s)
=== RUN   TestAccKubernetesService_generatedName
--- PASS: TestAccKubernetesService_generatedName (2.15s)
=== RUN   TestAccKubernetesService_importGeneratedName
--- PASS: TestAccKubernetesService_importGeneratedName (2.42s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/kubernetes	177.872s

@radeksimko
Copy link
Member Author 

The following packages are missing or modified locally:
	k8s.io/kubernetes/pkg/api/unversioned/validation
	k8s.io/kubernetes/pkg/api/validation/path
	k8s.io/kubernetes/pkg/apimachinery/announced
	k8s.io/kubernetes/pkg/apimachinery/registered
	k8s.io/kubernetes/pkg/apis/certificates/v1alpha1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/apps/v1beta1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/authentication/v1beta1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/authorization/v1beta1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/autoscaling/v1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/batch/v1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/batch/v2alpha1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/certificates/v1alpha1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/core/v1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/extensions/v1beta1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/policy/v1beta1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/rbac/v1alpha1
	k8s.io/kubernetes/pkg/client/clientset_generated/release_1_5/typed/storage/v1beta1
	k8s.io/kubernetes/pkg/client/restclient
	k8s.io/kubernetes/pkg/client/transport
	k8s.io/kubernetes/pkg/client/typed/discovery
	k8s.io/kubernetes/pkg/client/unversioned/auth
	k8s.io/kubernetes/pkg/client/unversioned/clientcmd
	k8s.io/kubernetes/pkg/client/unversioned/clientcmd/api
	k8s.io/kubernetes/pkg/client/unversioned/clientcmd/api/latest
	k8s.io/kubernetes/pkg/client/unversioned/clientcmd/api/v1
	k8s.io/kubernetes/pkg/genericapiserver/openapi/common
	k8s.io/kubernetes/pkg/selection
	k8s.io/kubernetes/pkg/util/cert
	k8s.io/kubernetes/pkg/util/clock
	k8s.io/kubernetes/pkg/util/flowcontrol
	k8s.io/kubernetes/pkg/util/homedir
	k8s.io/kubernetes/pkg/util/integer
	k8s.io/kubernetes/pkg/util/jsonpath
	k8s.io/kubernetes/plugin/pkg/client/auth
	k8s.io/kubernetes/plugin/pkg/client/auth/gcp
	k8s.io/kubernetes/plugin/pkg/client/auth/oidc
Error: status failed for 37 package(s)

hrm, 🤔 but these packages are supposed to be missing in the new version...

@radeksimko radeksimko mentioned this pull request May 30, 2017
Merged
@radeksimko radeksimko force-pushed the f-k8s-upgrade-1.6.1 branch from 12daf8b to 40c6d9b Compare May 30, 2017 15:20
grubernaut
grubernaut approved these changes May 30, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@radeksimko radeksimko merged commit b17bcd3 into master May 31, 2017
@radeksimko radeksimko deleted the f-k8s-upgrade-1.6.1 branch May 31, 2017 06:30
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
enhancement provider/kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @grubernaut